gaborgsomogyi commented on a change in pull request #27898:
[SPARK-31141][DSTREAMS][DOC] Add version information to the configuration of
Dstreams
URL: https://github.com/apache/spark/pull/27898#discussion_r395979038
##########
File path: docs/configuration.md
##########
@@ -2483,6 +2483,7 @@ Spark subsystems.
<code>spark.streaming.receiver.maxRate</code> and
<code>spark.streaming.kafka.maxRatePerPartition</code>
Review comment:
That said the added version in the `md` file is fine and we shouldn't revert
it (in order to have a complete config list with versions). The suggestion is
to add the version in the code like this:
```
private[spark] val MAX_RATE_PER_PARTITION =
ConfigBuilder("spark.streaming.kafka.maxRatePerPartition")
.version("1.3.0")
.longConf
.createWithDefault(0)
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
