HyukjinKwon commented on a change in pull request #27690: [SPARK-21514][SQL]
Added a new option to use non-blobstore storage when writing into blobstore
storage
URL: https://github.com/apache/spark/pull/27690#discussion_r396185493
##########
File path:
sql/hive/src/main/scala/org/apache/spark/sql/hive/execution/SaveAsHiveFile.scala
##########
@@ -97,7 +99,43 @@ private[hive] trait SaveAsHiveFile extends
DataWritingCommand {
options = Map.empty)
}
- protected def getExternalTmpPath(
+ /*
+ * Mostly copied from Context.java#getMRTmpPath of Hive 2.3
+ *
+ */
+ def getMRTmpPath(
+ hadoopConf: Configuration,
+ sessionScratchDir: String,
+ scratchDir: String): Path = {
+
+ // Hive's getMRTmpPath uses nonLocalScratchPath + '-mr-10000',
+ // which is ruled by 'hive.exec.scratchdir' including file system.
+ // This is the same as Spark's #oldVersionExternalTempPath
+ // Only difference between #oldVersionExternalTempPath and Hive 2.3.0's is
HIVE-7090
+ // HIVE-7090 added user_name/session_id on top of 'hive.exec.scratchdir'
+ // Here it uses session_path unless it's emtpy, otherwise uses scratchDir
+ val sessionPath =
Option(sessionScratchDir).filterNot(_.isEmpty).getOrElse(scratchDir)
Review comment:
Why do we need to do `Option` here if it becomes an empty string If
`_hive.hdfs.session.path` is empty?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
