cloud-fan commented on a change in pull request #27665: [SPARK-30623][Core]
Spark external shuffle allow disable of separate event loop group
URL: https://github.com/apache/spark/pull/27665#discussion_r396411190
##########
File path:
common/network-common/src/main/java/org/apache/spark/network/server/ChunkFetchRequestHandler.java
##########
@@ -65,17 +52,8 @@ public ChunkFetchRequestHandler(
this.maxChunksBeingTransferred = maxChunksBeingTransferred;
}
- @Override
- public void exceptionCaught(ChannelHandlerContext ctx, Throwable cause)
throws Exception {
- logger.warn("Exception in connection from " +
getRemoteAddress(ctx.channel()), cause);
- ctx.close();
- }
-
- @Override
- protected void channelRead0(
- ChannelHandlerContext ctx,
- final ChunkFetchRequest msg) throws Exception {
- Channel channel = ctx.channel();
+ public void processFetchRequest(
+ final Channel channel, final ChunkFetchRequest msg) throws Exception {
Review comment:
shall we define channel as a protected member variable?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
