HyukjinKwon commented on a change in pull request #27991: [SPARK-31227][SQL]
Non-nullable null type in complex types should not coerce to nullable type
URL: https://github.com/apache/spark/pull/27991#discussion_r396438243
##########
File path:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/Cast.scala
##########
@@ -211,7 +211,6 @@ object Cast {
}
def forceNullable(from: DataType, to: DataType): Boolean = (from, to) match {
- case (NullType, _) => true
Review comment:
`ArrayType(NullType, containsNull=False)` can't contain `null`, no?
> array(null) to array<int>
In this case, it should respect `containsNull` in each side.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
