turboFei commented on issue #27943: [SPARK-31179] Fast fail the connection while last connection failed in the last retry IO wait URL: https://github.com/apache/spark/pull/27943#issuecomment-602592168 > > > Currently we just run and timeout 3 times, and this PR proposes to fail fast. > > > > > > We should not be failing without retrying. Is that really what this does? I'd have to take a closer look but I thought the RetryingBlockFetcher caught this and did its normal retries within it, but that was my question yesterday to confirm? > > @cloud-fan @tgravescs IIUC, this PR only fail fast in a single one connection try but will still retry if it's a `RetryingBlockFetcher`. In fact, the current implementation in this patch would fast fail all connections. I just propose a compromise solution that just fast fail a single one connection in the comments. I prefer to fast fail all connections related with the unreachable ESS.
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
