rednaxelafx commented on issue #28008: [SPARK-27692][SQL] Constant fold deterministic Scala UDFs with foldable arguments URL: https://github.com/apache/spark/pull/28008#issuecomment-603599059 Thank you very much for linking this PR to the existing JIRA ticket and its PR! I vaguely remember this had been implemented before but didn't find it in master and got curious... now I know >_<||| It's highly likely that this PR won't be good enough to make the bar, but I'd like to hear other folks' opinions. Thanks. Basically this is a hurdle that we cannot get past until the APIs are clarified and the semantics of `ScalaUDF.deterministic` is strong enough for optimizations to depend on: https://github.com/apache/spark/pull/24593#pullrequestreview-237361795 I had the same concerns when sending out this PR, and I'm more than okay to withdraw and close this PR given the current state of the API/semantics.
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
