HyukjinKwon commented on a change in pull request #27999:
[SPARK-31232][SQL][DOCS] Specify formats of `spark.sql.session.timeZone`
URL: https://github.com/apache/spark/pull/27999#discussion_r397581770
##########
File path:
sql/catalyst/src/main/scala/org/apache/spark/sql/internal/SQLConf.scala
##########
@@ -1675,14 +1675,15 @@ object SQLConf {
Try { DateTimeUtils.getZoneId(zone) }.isSuccess
}
- val SESSION_LOCAL_TIMEZONE =
- buildConf("spark.sql.session.timeZone")
- .doc("""The ID of session local timezone, e.g. "GMT",
"America/Los_Angeles", etc.""")
- .version("2.2.0")
- .stringConf
- .checkValue(isValidTimezone, s"Cannot resolve the given timezone with" +
- " ZoneId.of(_, ZoneId.SHORT_IDS)")
- .createWithDefaultFunction(() => TimeZone.getDefault.getID)
+ val SESSION_LOCAL_TIMEZONE = buildConf("spark.sql.session.timeZone")
+ .doc("The ID of session local timezone in the format of either
region-based zone IDs or " +
+ "zone offsets. Region IDs must have the form 'area/city', such as
'America/Los_Angeles'. " +
+ "Zone offsets must be in the format '(+|-)HH:mm', for example '-08:00'
or '+01:00'.")
Review comment:
Actually why don't we add the simple reason about three-latters timezones?
Like you described in PR description: other formats such as three-letter
timezone IDs are ambitious
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
