viirya commented on a change in pull request #27902: [SPARK-31147][SQL] Forbid
CHAR type in non-Hive-Serde tables
URL: https://github.com/apache/spark/pull/27902#discussion_r397610129
##########
File path:
sql/catalyst/src/main/scala/org/apache/spark/sql/connector/catalog/CatalogV2Util.scala
##########
@@ -329,4 +331,19 @@ private[sql] object CatalogV2Util {
.getOrElse(catalogManager.v2SessionCatalog)
.asTableCatalog
}
+
+ def failCharType(dt: DataType): Unit = {
+ if (HiveStringType.containsCharType(dt)) {
+ throw new AnalysisException(
+ "Cannot use CHAR type in non-Hive-Serde tables, please use STRING type
instead.")
+ }
+ }
+
+ def assertNoCharTypeInSchema(schema: StructType): Unit = {
+ schema.foreach { f =>
+ if (f.metadata.contains(HIVE_TYPE_STRING)) {
+
failCharType(CatalystSqlParser.parseRawDataType(f.metadata.getString(HIVE_TYPE_STRING)))
+ }
Review comment:
Can we just disallow char type at parser? Like throwing exception in
`visitColType` when we find it?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
