Github user vanzin commented on a diff in the pull request:

    https://github.com/apache/spark/pull/4688#discussion_r25914669
  
    --- Diff: 
yarn/src/main/scala/org/apache/spark/deploy/yarn/YarnSparkHadoopUtil.scala ---
    @@ -82,6 +102,180 @@ class YarnSparkHadoopUtil extends SparkHadoopUtil {
         if (credentials != null) credentials.getSecretKey(new Text(key)) else 
null
       }
     
    +  private[spark] override def scheduleLoginFromKeytab(): Unit = {
    +    val principal = System.getenv("SPARK_PRINCIPAL")
    +    val keytab = System.getenv("SPARK_KEYTAB")
    +    if (principal != null) {
    +      val delegationTokenRenewerThread =
    +        new Runnable {
    +          override def run(): Unit = {
    +            if (!loggedInViaKeytab) {
    +              // Keytab is copied by YARN to the working directory of the 
AM, so full path is
    +              // not needed.
    +              loggedInUGI = 
UserGroupInformation.loginUserFromKeytabAndReturnUGI(
    +                principal, keytab)
    +              loggedInViaKeytab = true
    +            }
    +            val nns = getNameNodesToAccess(sparkConf)
    +            val newCredentials = loggedInUGI.getCredentials
    +            obtainTokensForNamenodes(nns, conf, newCredentials)
    +            val remoteFs = FileSystem.get(conf)
    +            val stagingDirPath =
    +              new Path(remoteFs.getHomeDirectory, 
System.getenv("SPARK_YARN_STAGING_DIR"))
    +            val tokenPathStr = sparkConf.get("spark.yarn.credentials.file")
    --- End diff --
    
    Couldn't you set `spark.yarn.credentials.file` to the full URL and avoid 
having to look at `SPARK_YARN_STAGING_DIR` in multiple places?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to