HyukjinKwon commented on a change in pull request #27728:
[SPARK-25556][SPARK-17636][SPARK-31026][SPARK-31060][SQL][test-hive1.2] Nested
Column Predicate Pushdown for Parquet
URL: https://github.com/apache/spark/pull/27728#discussion_r397742247
##########
File path:
sql/catalyst/src/main/scala/org/apache/spark/sql/sources/filters.scala
##########
@@ -32,6 +33,7 @@ import org.apache.spark.annotation.{Evolving, Stable}
sealed abstract class Filter {
/**
* List of columns that are referenced by this filter.
+ * Note that, if a column contains `dots` in name, it will be quoted to
avoid confusion.
Review comment:
I think the problem is that, it is one switch for all or none while the
problem can exist for source specifically.
I feel like this concern is underestimated. Dots in column names are not
very common in Spark world but I don't think it's not very rare in other
systems, Elasticsearch as an example
(https://github.com/elastic/elasticsearch/issues/15951).
Another concern is that, it's enabled by default. If we target 3.0, should
we maybe disable it by default? It's already right before cutting RC very soon.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
