Github user chenghao-intel commented on a diff in the pull request:

    https://github.com/apache/spark/pull/4918#discussion_r25918187
  
    --- Diff: sql/core/src/test/scala/org/apache/spark/sql/SQLQuerySuite.scala 
---
    @@ -1049,4 +1049,14 @@ class SQLQuerySuite extends QueryTest with 
BeforeAndAfterAll {
         rdd.toDF().registerTempTable("distinctData")
         checkAnswer(sql("SELECT COUNT(DISTINCT key,value) FROM distinctData"), 
Row(2))
       }
    +
    +  test("SPARK-6145: ORDER BY test for nested fields") {
    +    jsonRDD(sparkContext.makeRDD(
    +      """{"a": {"b": 1, "a": {"a": 1}}, "c": [{"d": 1}]}""" :: 
Nil)).registerTempTable("nestedOrder")
    +    // These should be successfully analyzed
    +    sql("SELECT 1 FROM nestedOrder ORDER BY a.b").queryExecution.analyzed
    +    sql("SELECT a.b FROM nestedOrder ORDER BY a.b").queryExecution.analyzed
    +    sql("SELECT 1 FROM nestedOrder ORDER BY a.a.a").queryExecution.analyzed
    +    sql("SELECT 1 FROM nestedOrder ORDER BY 
c[0].d").queryExecution.analyzed
    --- End diff --
    
    I've tried the latest master code in Spark SQL CLI:
    ```
    create table struct1 as select named_struct("a",key, "b", value) as a from 
src limit 1;
    select 1 from struct1 order by a.b; -- OK
    select a.a from struct1 order by a.b; -- failed
    select a.a from struct1 order by a.a; -- failed
    org.apache.spark.sql.AnalysisException: GetField is not valid on fields of 
type StringType;
        at 
org.apache.spark.sql.catalyst.analysis.Analyzer$ResolveReferences$.resolveGetField(Analyzer.scala:307)
        at 
org.apache.spark.sql.catalyst.analysis.Analyzer$ResolveReferences$$anonfun$apply$7$$anonfun$applyOrElse$2.applyOrElse(Analyzer.scala:271)
        at 
org.apache.spark.sql.catalyst.analysis.Analyzer$ResolveReferences$$anonfun$apply$7$$anonfun$applyOrElse$2.applyOrElse(Analyzer.scala:260)
        at 
org.apache.spark.sql.catalyst.trees.TreeNode$$anonfun$transformUp$1.apply(TreeNode.scala:250)
        at 
org.apache.spark.sql.catalyst.trees.TreeNode$$anonfun$transformUp$1.apply(TreeNode.scala:250)
        at 
org.apache.spark.sql.catalyst.trees.CurrentOrigin$.withOrigin(TreeNode.scala:50)
        at 
org.apache.spark.sql.catalyst.trees.TreeNode.transformUp(TreeNode.scala:249)
        at 
org.apache.spark.sql.catalyst.trees.TreeNode$$anonfun$5.apply(TreeNode.scala:263)
        at scala.collection.Iterator$$anon$11.next(Iterator.scala:328)
        at scala.collection.Iterator$class.foreach(Iterator.scala:727)
        at scala.collection.AbstractIterator.foreach(Iterator.scala:1157)
    ```


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to