cloud-fan commented on a change in pull request #28003: [SPARK-31234][SQL]
ResetCommand should reset config to sc.conf only
URL: https://github.com/apache/spark/pull/28003#discussion_r397751643
##########
File path:
sql/core/src/test/scala/org/apache/spark/sql/internal/SQLConfSuite.scala
##########
@@ -45,7 +45,7 @@ class SQLConfSuite extends QueryTest with SharedSparkSession
{
// Clear the conf.
spark.sessionState.conf.clear()
// After clear, only overrideConfs used by unit test should be in the
SQLConf.
- assert(spark.conf.getAll === TestSQLContext.overrideConfs)
+ assert((spark.conf.getAll -- TestSQLContext.overrideConfs.keys).size <
spark.conf.getAll.size)
Review comment:
is this still needed?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
