cloud-fan commented on a change in pull request #27991: [SPARK-31227][SQL]
Non-nullable null type in complex types should not coerce to nullable type
URL: https://github.com/apache/spark/pull/27991#discussion_r397840232
##########
File path:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/Cast.scala
##########
@@ -210,8 +206,16 @@ object Cast {
case _ => false // overflow
}
+ /**
+ * Returns `true` iff it should change the nullability of this type in map
type,
Review comment:
nit:
```
Returns true if casting non-nullable values from `from` type to `to` type
may return null.
Note that the caller side should take care of input nullability first and
only call this method
if the input is not nullable.
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
