MaxGekk commented on a change in pull request #28001: [SPARK-31237][SQL][TESTS]
Replace 3-letter time zones by zone offsets
URL: https://github.com/apache/spark/pull/28001#discussion_r398095971
##########
File path:
sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/util/DateTimeTestUtils.scala
##########
@@ -22,20 +22,31 @@ import java.util.TimeZone
import java.util.concurrent.TimeUnit
import org.apache.spark.sql.catalyst.util.DateTimeConstants._
+import org.apache.spark.sql.catalyst.util.DateTimeUtils.getZoneId
/**
* Helper functions for testing date and time functionality.
*/
object DateTimeTestUtils {
+ val CEST = getZoneId("+02:00")
+ val CET = getZoneId("+01:00")
+ val JST = getZoneId("+09:00")
Review comment:
I haven't found alternative definition of `JST` in
https://www.timeanddate.com/time/zones/
The problem of `JST` is it maps to `Asia/Tokyo`, see
https://github.com/frohoff/jdk8u-jdk/blob/master/src/share/classes/java/time/ZoneId.java#L241
And `Asia/Tokyo` had daylight saving time transitions before 8-Sep-1951.
Since `JST` is `+09:00` by definition, the changed line reflects this.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
