MaxGekk commented on a change in pull request #28016:
[SPARK-31238][SQL][test-hive1.2] Rebase dates to/from Julian calendar in
write/read for ORC datasource
URL: https://github.com/apache/spark/pull/28016#discussion_r398342307
##########
File path:
sql/hive/src/main/scala/org/apache/spark/sql/hive/HiveInspectors.scala
##########
@@ -32,6 +32,7 @@ import org.apache.spark.sql.AnalysisException
import org.apache.spark.sql.catalyst.InternalRow
import org.apache.spark.sql.catalyst.expressions._
import org.apache.spark.sql.catalyst.util._
+import org.apache.spark.sql.execution.datasources.DaysWritable
Review comment:
If I remove it, the build fails with:
```
Error:(1012, 44) not found: type DaysWritable
private def getDateWritable(value: Any): DaysWritable =
```
I moved `DaysWritable` from `sql/hive` to `sql/core` to reuse it in ORC.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
