HeartSaVioR commented on a change in pull request #28026: [SPARK-31257][SQL]
Unify create table syntax (WIP)
URL: https://github.com/apache/spark/pull/28026#discussion_r398404370
##########
File path:
sql/catalyst/src/main/java/org/apache/spark/sql/connector/catalog/TableCatalog.java
##########
@@ -46,6 +46,11 @@
*/
String PROP_LOCATION = "location";
+ /**
+ * A reserved property to specify a table was created with EXTERNAL.
+ */
+ String PROP_EXTERNAL = "external";
Review comment:
Because `LOCATION` supersedes `EXTERNAL` and all external tables require
location, right? If my understanding is correct, I agree `PROP_EXTERNAL` is
redundant and `PROP_LOCATION` can be used instead.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
