cloud-fan commented on a change in pull request #28018: [SPARK-31262][SQL][TESTS][FOLLOWUP] Fix bug tests imported bracketed comments URL: https://github.com/apache/spark/pull/28018#discussion_r398435094
########## File path: sql/core/src/test/resources/sql-tests/inputs/nested-comments.sql ########## @@ -0,0 +1,9 @@ +-- This test case just used to test imported bracketed comments. + +-- the first case of bracketed comment +--QUERY-DELIMITER-START +/* This is the first example of bracketed comment. +SELECT 'ommented out content' AS first; Review comment: maybe updating `SQLQueryTestSuite` only is good enough. It's an obvious bug that we forget to handle `QUERY-DELIMITER` in imported code. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
