maryannxue commented on a change in pull request #28022: [SPARK-31253][SQL] Add
metrics to AQE shuffle reader
URL: https://github.com/apache/spark/pull/28022#discussion_r398685778
##########
File path:
sql/core/src/main/scala/org/apache/spark/sql/execution/adaptive/OptimizeSkewedJoin.scala
##########
@@ -120,7 +120,8 @@ case class OptimizeSkewedJoin(conf: SQLConf) extends
Rule[SparkPlan] {
} else {
mapStartIndices(i + 1)
}
- PartialReducerPartitionSpec(reducerId, startMapIndex, endMapIndex)
+ val dataSize =
startMapIndex.until(endMapIndex).map(mapPartitionSizes(_)).sum
Review comment:
Would it make sense to make this size part of the return value from
`splitSizeListByTargetSize`?
Or even make `splitSizeListByTargetSize` return partition specs directly,
like the other utility func?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
