peter-toth opened a new pull request #28041: [WIP][SPARK-30564][SQL] Improved 
extra new line and comment remove
URL: https://github.com/apache/spark/pull/28041
 
 
   ### What changes were proposed in this pull request?
   
   SPARK-21870 
(https://github.com/apache/spark/commit/cb0cddffe9452937033e0e6b1fc0e600d2c787ad#diff-06dc5de6163687b7810aa76e7e152a76R146-R149)
 caused a significant performance regression where the number of rows is 
relatively low but the generated code size is large. This PR replaces the slow 
regular expression based comment and extra new line removal to a much faster 
custom code.
   
   ### Why are the changes needed?
   To fix performance regression.
   
   ### Does this PR introduce any user-facing change?
   No.
   
   ### How was this patch tested?
   Existing UTs.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to