holdenk commented on a change in pull request #27864: [SPARK-20732][CORE]
Decommission cache blocks to other executors when an executor is decommissioned
URL: https://github.com/apache/spark/pull/27864#discussion_r398947868
##########
File path: core/src/main/scala/org/apache/spark/storage/BlockManager.scala
##########
@@ -1560,26 +1567,30 @@ private[spark] class BlockManager(
def replicateBlock(
blockId: BlockId,
existingReplicas: Set[BlockManagerId],
- maxReplicas: Int): Unit = {
+ maxReplicas: Int,
+ forceFetch: Boolean = true,
+ maxReplicationFailures: Option[Int] = None): Boolean = {
+ var replicatedSuccessfully = true
Review comment:
Personally, I don't like var's we could factor this out by using map +
headOption + getOrElse but that might not be any cleaner so no pressure on this
suggestions.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
