ulysses-you commented on issue #28049: [SPARK-31285][CORE] Do not upper case 
schedule mode in TaskSchedulerImpl
URL: https://github.com/apache/spark/pull/28049#issuecomment-604899525
 
 
   > I think we should uppercase every where instead of lowercase, which is not 
acceptable for `SchedulingMode`.
   
   Yeah. It can be. 
   But if we use `SchedulingMode` at other place in future, we may forget upper 
it too.  I think the most simple way is keeping the raw string.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to