Github user mengxr commented on a diff in the pull request:
https://github.com/apache/spark/pull/4925#discussion_r25958607
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/attribute/AttributeType.scala ---
@@ -0,0 +1,61 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.spark.ml.attribute
+
+/**
+ * An enum-like type for attribute types: [[AttributeType$#Numeric]],
[[AttributeType$#Nominal]],
+ * and [[AttributeType$#Binary]].
+ */
+sealed abstract class AttributeType(val name: String)
+
+object AttributeType {
+
+ /** Numeric type. */
+ final val Numeric: AttributeType = {
+ case object Numeric extends AttributeType("numeric")
+ Numeric
+ }
+
+ /** Nominal type. */
+ final val Nominal: AttributeType = {
+ case object Nominal extends AttributeType("nominal")
+ Nominal
+ }
+
+ /** Binary type. */
+ final val Binary: AttributeType = {
+ case object Binary extends AttributeType("binary")
+ Binary
+ }
+
+ /**
+ * Gets the [[AttributeType]] object from its name.
+ * @param name attribute type name: "numeric", "nominal", or "binary"
+ */
+ def fromName(name: String): AttributeType = {
+ if (name == Numeric.name) {
--- End diff --
Yes. `match ... case ...` usually generates more byte code, but I didn't
verify it in this case. Let me check the bytecode.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
