Github user nchammas commented on a diff in the pull request:

    https://github.com/apache/spark/pull/4901#discussion_r25964792
  
    --- Diff: ec2/spark_ec2.py ---
    @@ -148,6 +160,10 @@ def parse_args():
             "-v", "--spark-version", default=DEFAULT_SPARK_VERSION,
             help="Version of Spark to use: 'X.Y.Z' or a specific git hash 
(default: %default)")
         parser.add_option(
    +        "--tachyon-version",
    +        default=DEFAULT_TACHYON_VERSION,
    +        help="When --spark-version is a git hash, this will be used as the 
version of Tachyon")
    --- End diff --
    
    The wording here is a little confusing, I think. So this option only takes 
effect if `--spark-version` is a git hash and otherwise it is ignored, right?
    
    And what's the purpose of the default value here? Doesn't seem to ever come 
into play.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to