MaxGekk opened a new pull request #28057: [WIP][SQL] Benchmark rebasing of dates/timestamps URL: https://github.com/apache/spark/pull/28057 TL&DR I benchmarked save/load for Parquet: - Saving is **~6 times slower** - Loading w/ vectorized **off** is **~4 times slower** - Loading w/ vectorized **on** is **~11 times slower** Here is the results I got on my laptop: ``` Java HotSpot(TM) 64-Bit Server VM 1.8.0_231-b11 on Mac OS X 10.15.3 Intel(R) Core(TM) i7-4850HQ CPU @ 2.30GHz Save timestamps to parquet: Best Time(ms) Avg Time(ms) Stdev(ms) Rate(M/s) Per Row(ns) Relative ------------------------------------------------------------------------------------------------------------------------ after 1582, noop 2265 2265 0 44.2 22.6 1.0X after 1582, rebase off 13689 13689 0 7.3 136.9 0.2X after 1582, rebase on 71073 71073 0 1.4 710.7 0.0X before 1582, noop 2118 2118 0 47.2 21.2 1.1X before 1582, rebase off 14442 14442 0 6.9 144.4 0.2X before 1582, rebase on 78824 78824 0 1.3 788.2 0.0X Java HotSpot(TM) 64-Bit Server VM 1.8.0_231-b11 on Mac OS X 10.15.3 Intel(R) Core(TM) i7-4850HQ CPU @ 2.30GHz Load timestamps from parquet: Best Time(ms) Avg Time(ms) Stdev(ms) Rate(M/s) Per Row(ns) Relative ------------------------------------------------------------------------------------------------------------------------ after 1582, vec off, rebase off 12025 12326 390 8.3 120.2 1.0X after 1582, vec off, rebase on 51214 52395 1724 2.0 512.1 0.2X after 1582, vec on, rebase off 3798 3848 71 26.3 38.0 3.2X after 1582, vec on, rebase on 42998 43137 138 2.3 430.0 0.3X before 1582, vec off, rebase off 11692 11793 140 8.6 116.9 1.0X before 1582, vec off, rebase on 52789 52973 173 1.9 527.9 0.2X before 1582, vec on, rebase off 3832 3871 48 26.1 38.3 3.1X after 1582, vec on, rebase on 44904 44956 66 2.2 449.0 0.3X ``` <!-- Thanks for sending a pull request! Here are some tips for you: 1. If this is your first time, please read our contributor guidelines: https://spark.apache.org/contributing.html 2. Ensure you have added or run the appropriate tests for your PR: https://spark.apache.org/developer-tools.html 3. If the PR is unfinished, add '[WIP]' in your PR title, e.g., '[WIP][SPARK-XXXX] Your PR title ...'. 4. Be sure to keep the PR description updated to reflect all changes. 5. Please write your PR title to summarize what this PR proposes. 6. If possible, provide a concise example to reproduce the issue for a faster review. 7. If you want to add a new configuration, please read the guideline first for naming configurations in 'core/src/main/scala/org/apache/spark/internal/config/ConfigEntry.scala'. --> ### What changes were proposed in this pull request? <!-- Please clarify what changes you are proposing. The purpose of this section is to outline the changes and how this PR fixes the issue. If possible, please consider writing useful notes for better and faster reviews in your PR. See the examples below. 1. If you refactor some codes with changing classes, showing the class hierarchy will help reviewers. 2. If you fix some SQL features, you can provide some references of other DBMSes. 3. If there is design documentation, please add the link. 4. If there is a discussion in the mailing list, please add the link. --> ### Why are the changes needed? <!-- Please clarify why the changes are needed. For instance, 1. If you propose a new API, clarify the use case for a new API. 2. If you fix a bug, you can clarify why it is a bug. --> ### Does this PR introduce any user-facing change? <!-- If yes, please clarify the previous behavior and the change this PR proposes - provide the console output, description and/or an example to show the behavior difference if possible. If no, write 'No'. --> ### How was this patch tested? <!-- If tests were added, say they were added here. Please make sure to add some test cases that check the changes thoroughly including negative and positive cases if possible. If it was tested in a way different from regular unit tests, please clarify how you tested step by step, ideally copy and paste-able, so that other reviewers can test and check, and descendants can verify in the future. If tests were not added, please describe why they were not added and/or why it was difficult to add. -->
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
