Github user shivaram commented on a diff in the pull request:
https://github.com/apache/spark/pull/4783#discussion_r25969340
--- Diff: core/src/main/scala/org/apache/spark/util/SizeEstimator.scala ---
@@ -257,21 +262,56 @@ private[spark] object SizeEstimator extends Logging {
val parent = getClassInfo(cls.getSuperclass)
var shellSize = parent.shellSize
var pointerFields = parent.pointerFields
+
+ // we have only four sizes: 1, 2, 4, 8. pointerSize can be 4 or 8.
+ // we can just use an Array.fill(8 + 1) to hold all the size counting,
but we
+ // can also use a HashMap to store size counting; Here we uses Array.
+ val sizeCount = Array.fill(fieldSizes.max + 1)(0)
+ // iterate through the fields of this class and gather information.
for (field <- cls.getDeclaredFields) {
if (!Modifier.isStatic(field.getModifiers)) {
val fieldClass = field.getType
if (fieldClass.isPrimitive) {
- shellSize += primitiveSize(fieldClass)
+ sizeCount(primitiveSize(fieldClass)) += 1
} else {
field.setAccessible(true) // Enable future get()'s on this field
- shellSize += pointerSize
+ sizeCount(pointerSize) += 1
pointerFields = field :: pointerFields
}
}
}
- shellSize = alignSize(shellSize)
+ // Based on the simulated field layout code in Aleksey Shipilev's
report:
--- End diff --
You can delete the two lines
```
Aleksey Shiplev also leaders the development of JOL (Java Object
Layout) tool. The simulated code is also in the JOL.
```
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
