HeartSaVioR edited a comment on issue #28026: [SPARK-31257][SQL] Unify create 
table syntax (WIP)
URL: https://github.com/apache/spark/pull/28026#issuecomment-605538309
 
 
   Same here, please describe TODO list for this PR to remove WIP.
   
   If I skimmed the code correctly, this "requires" end users to add `USING 
hive` even they add Hive create table specific clause. Do I understand 
correctly?
   
   It's OK if that's one of TODO that let some clauses change the provider - we 
should concern about documentation to make clear which clause changes the 
provider. (Personally I'm not in favor of this, but otherwise why not just add 
`HIVE` to second syntax as both are requiring end users to change their query 
and adding `HIVE` is clearer?)
   
   If the change is intentional, that's my favor but I may concern about 
removing compatibility flag, as this will force end users to migrate their 
query in any way.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to