Github user tdas commented on the pull request:
https://github.com/apache/spark/pull/4875#issuecomment-77644096
This is a good idea. However the PR needs a bit more work.
1. You have add unit tests in the WindowOperationsSuite in Scala. The tests
should verify the results for multiple batches as the window slides over all
the initial RDDs. Also boundary conditions like what happens if you give 10
initial RDDs but the window = 5x the batch interval (the first 6 initial RDDs
should be ignored and never processed). The Java test looks fine.
2. Please add the python API as well. And python unit tests similar to the
Scala to ensure python does not mess up the ordering of initial rdds, etc.
3. You probably have to add binary compatibility exclusions. I am starting
the test but it will fail. The output of the test will tell you what to add in
the MimaExcludes.scala.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
