HeartSaVioR commented on a change in pull request #28019: [SPARK-31021][SQL]
Support MariaDB Kerberos login in JDBC connector
URL: https://github.com/apache/spark/pull/28019#discussion_r399785210
##########
File path:
external/docker-integration-tests/src/test/scala/org/apache/spark/sql/jdbc/DockerJDBCIntegrationSuite.scala
##########
@@ -53,11 +53,21 @@ abstract class DatabaseOnDocker {
*/
val jdbcPort: Int
+ /**
+ * Optional database name to connect to (not all database drivers need this).
+ */
+ var dbName: Option[String]
+
/**
* Return a JDBC URL that connects to the database running at the given IP
address and port.
*/
def getJdbcUrl(ip: String, port: Int): String
+ /**
+ * Optional entry point when container starts
+ */
+ def getEntryPoint: Option[String]
Review comment:
Maybe better to elaborate more on `entry point` - which value is expected
and how the entry point is supposed to be used.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
