sekikn commented on a change in pull request #28063:
[SPARK-31293][DSTREAMS][Kinesis][DOC] Fix wrong examples and help messages for
Kinesis integration
URL: https://github.com/apache/spark/pull/28063#discussion_r399837352
##########
File path:
external/kinesis-asl/src/main/scala/org/apache/spark/examples/streaming/KinesisWordCountASL.scala
##########
@@ -78,7 +78,7 @@ object KinesisWordCountASL extends Logging {
if (args.length != 3) {
System.err.println(
"""
- |Usage: KinesisWordCountASL <app-name> <stream-name> <endpoint-url>
<region-name>
Review comment:
`KinesisWordCountASL.scala` doesn't require the fourth argument (region)
because it's derived from the third argument (endpoint URL) using [the
`getRegionNameByEndpoint`
function](https://github.com/apache/spark/blob/master/external/kinesis-asl/src/main/scala/org/apache/spark/examples/streaming/KinesisExampleUtils.scala).
On the other hand, `kinesis_wordcount_asl.py` requires the fourth argument
because it doesn't have that function. So I removed that parameter from the
Scala example and added it to the Python example.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
