GitHub user JoshRosen opened a pull request:

    https://github.com/apache/spark/pull/4935

    [SPARK-6209] Clean up connections in ExecutorClassLoader after failing to 
load classes

    ExecutorClassLoader does not ensure proper cleanup of network connections 
that it opens. If it fails to load a class, it may leak partially-consumed 
InputStreams that are connected to the REPL's HTTP class server, causing that 
server to exhaust its thread pool, which can cause the entire job to hang.  See 
[SPARK-6209](https://issues.apache.org/jira/browse/SPARK-6209) for more 
details, including a bug reproduction.
    
    This patch fixes this issue by ensuring proper cleanup of these resources.  
It also adds logging for unexpected error cases.
    
    This class was renamed and heavily-refactored in Spark 1.3+, so I'll open a 
separate PR to fix this issue there.  This PR should 

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/JoshRosen/spark executorclassloader-leak

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/spark/pull/4935.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #4935
    
----
commit cc685a80f07aef88a53091bd4bb454c624c38ee7
Author: Josh Rosen <[email protected]>
Date:   2015-03-06T22:44:26Z

    Properly clean up after errors in ExecutorClassLoader
    
    Conflicts:
        repl/src/main/scala/org/apache/spark/repl/ExecutorClassLoader.scala

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to