Github user tdas commented on a diff in the pull request:

    https://github.com/apache/spark/pull/4723#discussion_r25986066
  
    --- Diff: python/pyspark/streaming/kafka.py ---
    @@ -70,7 +71,103 @@ def createStream(ssc, zkQuorum, groupId, topics, 
kafkaParams={},
             except Py4JJavaError, e:
                 # TODO: use --jar once it also work on driver
                 if 'ClassNotFoundException' in str(e.java_exception):
    -                print """
    +                KafkaUtils._printErrorMsg(ssc.sparkContext)
    +            raise e
    +        ser = PairDeserializer(NoOpSerializer(), NoOpSerializer())
    +        stream = DStream(jstream, ssc, ser)
    +        return stream.map(lambda (k, v): (keyDecoder(k), valueDecoder(v)))
    +
    +    @staticmethod
    +    def createDirectStream(ssc, brokerList, topics, kafkaParams={},
    +                           keyDecoder=utf8_decoder, 
valueDecoder=utf8_decoder):
    +        """
    --- End diff --
    
    Also, taking a broker list is different from the Scala / Java API. We 
should keep this consistent with the Scala / Java API. 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to