cloud-fan commented on a change in pull request #28037: [SPARK-31271][UI] fix
web ui for driver side SQL metrics
URL: https://github.com/apache/spark/pull/28037#discussion_r399905645
##########
File path:
sql/core/src/main/scala/org/apache/spark/sql/execution/metric/SQLMetrics.scala
##########
@@ -204,19 +204,21 @@ object SQLMetrics {
}
val validValues = values.filter(_ >= 0)
- val Seq(sum, min, med, max) = {
- val metric = if (validValues.isEmpty) {
- val zeros = Seq.fill(4)(0L)
- zeros.map(v => strFormat(v))
- } else {
+ // When there are only 1 metrics value (or None), no need to display
max/min/median. This is
+ // common for driver-side SQL metrics.
+ if (validValues.length <= 1) {
+ strFormat(validValues.headOption.getOrElse(0))
+ } else {
+ val Seq(sum, min, med, max) = {
Arrays.sort(validValues)
- Seq(strFormat(validValues.sum), strFormat(validValues(0)),
+ Seq(
+ strFormat(validValues.sum),
+ strFormat(validValues(0)),
strFormat(validValues(validValues.length / 2)),
- s"${strFormat(validValues(validValues.length - 1))} $stringMetric")
+ strFormat(validValues(validValues.length - 1)))
}
- metric
+ s"total $METRICS_NAME_SUFFIX\n$sum ($min, $med, $max $taskInfo)"
}
- s"\n$sum ($min, $med, $max)"
Review comment:
I think it was a mistake. We should have the task info for all the max
values.
BTW thanks for catching! I didn't realize it when I was working on this PR
...
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
