zhengruifeng commented on a change in pull request #28045: [SPARK-31283][ML]
Simplify ChiSq by adding a common method
URL: https://github.com/apache/spark/pull/28045#discussion_r399935947
##########
File path:
mllib/src/main/scala/org/apache/spark/mllib/stat/test/ChiSqTest.scala
##########
@@ -224,12 +170,11 @@ private[spark] object ChiSqTest extends Logging {
if (results.size < numFeatures) {
Review comment:
This is covered in `ChiSquareTestSuite` via case `test DataFrame of sparse
points`.
The values of the last feature are always zero, it will trigger this `if
(results.size < numFeatures)` path
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
