HyukjinKwon commented on a change in pull request #28048:
[SPARK-31142][PYSPARK]Remove useless conf set in pyspark context
URL: https://github.com/apache/spark/pull/28048#discussion_r399957870
##########
File path: python/pyspark/context.py
##########
@@ -181,11 +181,6 @@ def _do_init(self, master, appName, sparkHome, pyFiles,
environment, batchSize,
self.appName = self._conf.get("spark.app.name")
self.sparkHome = self._conf.get("spark.home", None)
- for (k, v) in self._conf.getAll():
Review comment:
> As pyspark always overwrites the jvm environment, the environment, passed
into python worker, will be invalidated.
Are you saying you're relying on an environment that was not set by
`spark.executorEnv.*`? The correct way to set the environment variables is to
use `spark.executorEnv.*` explicitly. It is correct for `spark.executorEnv.*`
to overwrite the environment variables.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
