Ngone51 commented on a change in pull request #28053: [SPARK-29153][CORE]Add
ability to merge resource profiles within a stage with Stage Level Scheduling
URL: https://github.com/apache/spark/pull/28053#discussion_r399973843
##########
File path: core/src/main/scala/org/apache/spark/internal/config/package.scala
##########
@@ -1814,4 +1814,8 @@ package object config {
.bytesConf(ByteUnit.BYTE)
.createOptional
+ private[spark] val RESOURCE_PROFILE_MERGE_CONFLICTS =
+ ConfigBuilder("spark.scheduler.resourceProfile.mergeConflicts")
+ .booleanConf
Review comment:
When I look through confs which introduced around the feature, I feel that
they're kind of messy. For example, we already have:
- spark.resources.discoveryPlugin
- spark.driver.resourcesFile
- spark.driver.resource.GPU.amount
Since they're all from the same feature, so I'm thinking that if we can make
them under the same namespace, e.g. `spark.resource`.
WDYT?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
