HyukjinKwon commented on a change in pull request #28056: [SPARK-31288][SQL]
Reduce calls to Hive Metastore
URL: https://github.com/apache/spark/pull/28056#discussion_r400008389
##########
File path:
sql/core/src/main/scala/org/apache/spark/sql/execution/command/ddl.scala
##########
@@ -234,7 +235,7 @@ case class DropTableCommand(
}
}
- if (isTempView || catalog.tableExists(tableName)) {
+ if (isTempView || isTableExist) {
Review comment:
Hm, @wangyum, when `isTempView` is `true`, `catalog.tableExists(tableName)`
won't be called by short-circuiting. So, this isn't a clean improvement but it
has trade-off. Can you clarify this trade-off as well?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
