Github user koeninger commented on a diff in the pull request:
https://github.com/apache/spark/pull/4805#discussion_r25990683
--- Diff:
external/kafka/src/main/scala/org/apache/spark/streaming/kafka/DirectKafkaInputDStream.scala
---
@@ -158,4 +166,37 @@ class DirectKafkaInputDStream[
}
}
+ private[streaming]
+ class DirectKafkaStreamingListener extends StreamingListener {
+
+ val offsetCommitEnabled =
context.conf.getBoolean("spark.streaming.kafka.offsetCommit", false)
+
+ val zkClientOpt = if (offsetCommitEnabled) {
+ kafkaParams.get("zookeeper.connect").map { zkConnect =>
--- End diff --
Doing things this way now means that zookeeper connect is required in the
kafka params, whereas it was not previously.
Why not use the existing setConsumerOffset methods in KafkaCluster? That
also means that this could more easily be updated to work with Kafka-based
consumer offset storage post-0.8.2
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
