xuanyuanking opened a new pull request #28072: Revert [SPARK-29285][SHUFFLE] Temporary shuffle files should be able to handle disk failures URL: https://github.com/apache/spark/pull/28072 ### What changes were proposed in this pull request? This reverts commit 8cf76f8d61b393bb3abd9780421b978e98db8cae. ### Why are the changes needed? It caused a performance regression for short-running queries. List some benchmark below: Env: Spark local-cluster[2, 4, 19968], each queries run 5 round, each round 5 times. Data: TPC-DS scale=99 generate by spark-tpcds-datagen Results: | | Base | Revert | |-----|---------------------------------------------------------------------------------------------|---------------------------------------------------------------------------------------------| | Q20 | Vector(4.096865667, 2.76231748, 2.722007606, 2.514433591, 2.400373579) Median 2.722007606 | Vector(3.763185446, 2.586498463, 2.593472842, 2.320522846, 2.224627274) Median 2.586498463 | | Q32 | Vector(1.48295701, 1.226271696, 1.067944786, 1.004792897, 0.928397749) Median 1.067944786 | Vector(1.422562007, 1.222849263, 1.047011181, 1.089932887, 0.909000602) Median 1.089932887 | | Q33 | Vector(5.872176321, 4.854397586, 4.568787136, 4.393378146, 4.423996818) Median 4.568787136 | Vector(5.38746785, 4.361236877, 4.082311276, 3.867206824, 3.783188024) Median 4.082311276 | | Q52 | Vector(3.978870321, 3.225437871, 3.282411608, 2.869674887, 2.644490664) Median 3.225437871 | Vector(4.000381522, 3.196025108, 3.248787619, 2.767444508, 2.606163423) Median 3.196025108 | | Q56 | Vector(6.238045133, 4.820535173, 4.609965579, 4.313509894, 4.221256227) Median 4.609965579 | Vector(6.241611339, 4.225592467, 4.195202502, 3.757085755, 3.657525982) Median 4.195202502 | ### Does this PR introduce any user-facing change? No ### How was this patch tested? Existing tests.
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
