rdblue commented on a change in pull request #27992: [SPARK-31230][SQL] Use
statement plans in DataFrameWriter(V2)
URL: https://github.com/apache/spark/pull/27992#discussion_r400381738
##########
File path: sql/core/src/main/scala/org/apache/spark/sql/DataFrameWriterV2.scala
##########
@@ -120,19 +117,18 @@ final class DataFrameWriterV2[T] private[sql](table:
String, ds: Dataset[T])
}
override def create(): Unit = {
- // create and replace could alternatively create ParsedPlan statements,
like
- // `CreateTableFromDataFrameStatement(UnresolvedRelation(tableName),
...)`, to keep the catalog
- // resolution logic in the analyzer.
runCommand("create") {
- CreateTableAsSelect(
- catalog,
- identifier,
- partitioning.getOrElse(Seq.empty),
+ CreateTableAsSelectStatement(
Review comment:
I think it's a good idea to deprecate table options, but that doesn't really
matter here. For this PR, we should keep write options separate from table
options because they are used for different things.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
