kiszk commented on a change in pull request #28041: [SPARK-30564][SQL] Improved
extra new line and comment remove
URL: https://github.com/apache/spark/pull/28041#discussion_r400308973
##########
File path:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/codegen/CodeFormatter.scala
##########
@@ -95,9 +95,128 @@ object CodeFormatter {
new CodeAndComment(code.result().trim(), map)
}
- def stripExtraNewLinesAndComments(input: String): String = {
+ def stripExtraNewLinesAndCommentsUsingRegexp(input: String): String = {
extraNewLinesRegexp.replaceAllIn(commentRegexp.replaceAllIn(input, ""),
"\n")
Review comment:
How about calling `commentRegexp.replaceAllIn` only when we find `/` in
`input`? Since the number of the lines with a comment is not large, I imagine
that the regex spends the time for searching lines.
It is necessary to process each line.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
