imback82 commented on a change in pull request #27992: [SPARK-31230][SQL] Use
statement plans in DataFrameWriter(V2)
URL: https://github.com/apache/spark/pull/27992#discussion_r400476614
##########
File path: sql/core/src/main/scala/org/apache/spark/sql/DataFrameWriter.scala
##########
@@ -578,27 +573,35 @@ final class DataFrameWriter[T] private[sql](ds:
Dataset[T]) {
AppendData.byName(v2Relation, df.logicalPlan, extraOptions.toMap)
case (SaveMode.Overwrite, _) =>
- ReplaceTableAsSelect(
- catalog,
- ident,
- partitioningAsV2,
+ ReplaceTableAsSelectStatement(
+ nameParts,
df.queryExecution.analyzed,
- Map(TableCatalog.PROP_PROVIDER -> source) ++ getLocationIfExists,
+ partitioningAsV2,
+ None,
Review comment:
Not related to this PR, but do we plan to support buckets for datasource V2?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
