Eric5553 commented on a change in pull request #27897: [SPARK-31113][SQL] Add
SHOW VIEWS command
URL: https://github.com/apache/spark/pull/27897#discussion_r401068120
##########
File path:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/plans/logical/statements.scala
##########
@@ -343,6 +343,15 @@ case class ShowTableStatement(
partitionSpec: Option[TablePartitionSpec])
extends ParsedStatement
+/**
+ * A SHOW VIEWS statement, as parsed from SQL.
+ */
+case class ShowViewsStatement(
Review comment:
@cloud-fan I did the implementation and got two more questions:
1. With the v2 command style, we need to extend the `CatalogPlugin` to
support view related interface. Which way do you prefer, add listViews function
to `TableCatalog` or add new interface `SupportViews`?
2. The current `CatalogPlugin` also does not support `isTemporaryTable`
check, so the v2 `ShowTablesExec` and `ShowViewsExec` can not support the
isTemporary output column. Do we need to handle it here?
Directly calling `SessionCatalog` API instead of 'CatalogPlugin' seems not
elegant here, right?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
