cloud-fan commented on a change in pull request #27897: [SPARK-31113][SQL] Add 
SHOW VIEWS command
URL: https://github.com/apache/spark/pull/27897#discussion_r401078298
 
 

 ##########
 File path: 
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/plans/logical/statements.scala
 ##########
 @@ -343,6 +343,15 @@ case class ShowTableStatement(
     partitionSpec: Option[TablePartitionSpec])
   extends ParsedStatement
 
+/**
+ * A SHOW VIEWS statement, as parsed from SQL.
+ */
+case class ShowViewsStatement(
 
 Review comment:
   Let's not add the view APIs for now, as it needs more design work. And seems 
like we need a v1 version as there is no view in v2 api.
   
   So my suggestion is:
   1. have the v2 style `ShowViews`, without the physical plan as v2 catalog 
doesn't have view
   2. in `ResolveSessionCatalog`, catch `ShowViews` and fail if the catalog is 
not a session catalog. Otherwise, convert it v1 style `ShowViewsCommand`.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to