maropu commented on issue #28041: [SPARK-30564][SQL] Improved extra new line 
and comment remove
URL: https://github.com/apache/spark/pull/28041#issuecomment-606960746
 
 
   Probably, all the comments in the generated codes should appear with 
`CodegenContext.registerComment`. If so, I think we don't need to strip the 
comments in 
https://github.com/apache/spark/blob/master/sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/codegen/CodeGenerator.scala#L926.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to