srowen commented on issue #28078: [SPARK-31309][ML] Migrate the ChiSquareTest from MLlib to ML URL: https://github.com/apache/spark/pull/28078#issuecomment-607210720 It's not a bad change and I don't mind some cleanup personally; some are just formatting changes. The general pattern is to let .ml reuse code in .mllib where they need to share, rather than both point to each other. I'm sure there are cases of both unfortunately (? I'd have to check). I might not move the code just to move it though unless it buys some simplification. But yet the logic here doesn't depend on whether .mllib will be removed. That isn't an end goal as far as I can tell.
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
