dongjoon-hyun commented on a change in pull request #28081: [SPARK-31315][SQL]
SQLQueryTestSuite: Display the total compile time for generated java code
URL: https://github.com/apache/spark/pull/28081#discussion_r401916067
##########
File path:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/codegen/CodeGenerator.scala
##########
@@ -1309,6 +1309,13 @@ object CodeGenerator extends Logging {
// bytecode instruction
final val MUTABLESTATEARRAY_SIZE_LIMIT = 32768
+ // Display the total compile time for generating java code in the output of
the test case.
Review comment:
Although this is designed for a test case, in this context, this is a
general accumulator in `CodeGenerator`. Could you revise into a more proper
description?
cc @gatorsmile
Also, this doesn't `Display` here. The warning log happens in `afterAll` in
`SQLQueryTestSuite`.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
