rdblue commented on issue #28026: [SPARK-31257][SQL] Unify create table syntax 
(WIP)
URL: https://github.com/apache/spark/pull/28026#issuecomment-607544833
 
 
   The [last test 
results](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/120684/testReport)
 were mostly tests that failed because of the syntax differences. Those tests 
used SQL syntax that couldn't be parsed by the DataSource CREATE rule, but also 
didn't specify either USING or Hive storage options. That shows that there were 
at least a lot of test queries silently affected by this ambiguity that were 
uncovered by unifying the syntax.
   
   To avoid too many changes in this PR, I changed the default to create Hive 
tables. That fixes most of the tests that I looked at and we'll see how the 
next run goes. We will eventually have to fix these tests when we swap the 
default, so they set the property to create Hive tables. But modifying so many 
tests should be done in a separate PR to keep this small and get it in more 
quickly.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to