maropu commented on a change in pull request #27897: [SPARK-31113][SQL] Add
SHOW VIEWS command
URL: https://github.com/apache/spark/pull/27897#discussion_r401976286
##########
File path:
sql/core/src/main/scala/org/apache/spark/sql/catalyst/analysis/ResolveSessionCatalog.scala
##########
@@ -545,6 +538,20 @@ class ResolveSessionCatalog(
replace,
viewType)
+ case ShowViews(resolved: ResolvedNamespace, pattern) =>
+ resolved match {
+ case SessionCatalogAndNamespace(_, ns) =>
+ // Fallback to v1 ShowViewsCommand since there is no view API in v2
catalog
+ assert(ns.nonEmpty)
+ if (ns.length != 1) {
+ throw new AnalysisException(s"The database name is not valid:
${ns.quoted}")
+ }
+ ShowViewsCommand(Some(ns.head), pattern)
+ case _ =>
+ throw new AnalysisException(s"Catalog ${resolved.catalog.name}
doesn't support " +
+ s"SHOW VIEWS, only SessionCatalog supports this command.")
Review comment:
nit: remove `s` in the head.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
