HyukjinKwon commented on issue #28026: [SPARK-31257][SQL] Unify create table syntax (WIP) URL: https://github.com/apache/spark/pull/28026#issuecomment-607658943 Sorry if this is answered above but why do we handle v2 APIs here together? V2 APIs are in development, and we can make the changes after Spark 3.0 too whereas seems it's best to unify the syntax in Spark 3.0 first considering it passed code freeze and now it's RC period. Can we split these two separately if I am not mistaken? Also, @rdblue, please read the PR template and follow the guide there for PR description (https://github.com/apache/spark/blob/master/.github/PULL_REQUEST_TEMPLATE). From a glance, seems difficult to follow +1,328 −1,134 changes, and what this PR really proposes. I strongly think this is a bad pattern to avoid for big PRs, which I initially aimed to address at https://github.com/apache/spark/pull/25310.
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
