Github user srowen commented on a diff in the pull request:

    https://github.com/apache/spark/pull/4899#discussion_r26038573
  
    --- Diff: 
examples/src/main/scala/org/apache/spark/examples/mllib/LDAExample.scala ---
    @@ -174,6 +174,7 @@ object LDAExample {
     
         // Get dataset of document texts
         // One document per line in each text file.
    +    // One partition each text file. Consider using coalesce as necessary.
    --- End diff --
    
    As long as we're documenting this, let's edit this a bit more. It's not 
guaranteed that there will be a partition per text file. I'd say something more 
like:
    
    "If the input consists of many small files, this can result in a large 
number of small partitions, which can degrade performance. In this case, 
consider using coalesce() to create fewer, larger partitions."


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to